BUG1413418: Enable pybsn to connect to port 443 with the /sys/api prefix#411
BUG1413418: Enable pybsn to connect to port 443 with the /sys/api prefix#411Kinjal-Arista wants to merge 10 commits intobigswitch:mainfrom
Conversation
Enables pybsn to automatically discover and connect to BigDB services that have been migrated to port 443 with the /sys/api prefix
Kinjal-Arista
requested review from
andi-bigswitch,
pazur-arista and
seamusarista
pybsn/__init__.py
Outdated
| ("https", 8443, ""), | ||
| ("http", 8080, ""), |
There was a problem hiding this comment.
do we want to also try with the /sys prefix on these ports?
There was a problem hiding this comment.
I thought if we are running pybsn and the connection via port 443 and the /sys prefix fails, that would indicate we are running it in a older floodlight version where it is not supported. So, any of the other ports with the sys prefix also wouldn't work. So, I didn't add it to the other ports
pybsn/__init__.py
Outdated
| return response | ||
|
|
||
|
|
||
| ATLAS_PREFIX = "/a" |
There was a problem hiding this comment.
nit: I'm not sure if we want to name it "ATLAS", this is a public package. I also don't see much point in having this as an extra constant, that is just embedded in other constant and is not used stand-alone (not counting unit tests)
There was a problem hiding this comment.
I don't have a strong opinion either way, so ok to delete it. But given it's repeated lots of times (11) in the code I'd prefer to have something. Naming is difficult...
3 participants
Enables pybsn to automatically discover and connect to BigDB services
that have been migrated to port 443 with the /sys/api prefix
Fixes: BUG1413418